Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that magnolia compiled by 3.3.3 (or 3.3.4) causes
scala/scala3#22499
which is due to a tree with
NoSpan
. I believe it is theIdent
in thisunchecked
annotation:https://github.com/softwaremill/magnolia/blob/scala3/core/src/main/scala/magnolia1/impl.scala#L120
I have verified that a couple of the projects erroring at the ticket (which depend directly or indirectly on magnolia) work after just publishing locally with 3.3.5. (That is, a project using 3.7 consuming magnolia built by 3.3.5.)
Sorry I haven't yet nailed down what the fix is on 3.3.5.
The symptom is that on 3.7
-Wunused:imports
uses the span but must code defensively. I don't know yet whether it's strictly a bug that a tree has a position that has no span. The defensive fix is atscala/scala3#22504