Skip to content

Use latest LTS 3.3.5 #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Use latest LTS 3.3.5 #579

merged 2 commits into from
Feb 25, 2025

Conversation

som-snytt
Copy link
Contributor

I discovered that magnolia compiled by 3.3.3 (or 3.3.4) causes

scala/scala3#22499

which is due to a tree with NoSpan. I believe it is the Ident in this unchecked annotation:

https://github.com/softwaremill/magnolia/blob/scala3/core/src/main/scala/magnolia1/impl.scala#L120

I have verified that a couple of the projects erroring at the ticket (which depend directly or indirectly on magnolia) work after just publishing locally with 3.3.5. (That is, a project using 3.7 consuming magnolia built by 3.3.5.)

Sorry I haven't yet nailed down what the fix is on 3.3.5.

The symptom is that on 3.7 -Wunused:imports uses the span but must code defensively. I don't know yet whether it's strictly a bug that a tree has a position that has no span. The defensive fix is at

scala/scala3#22504

@adamw adamw merged commit 5be4e9a into softwaremill:scala3 Feb 25, 2025
5 checks passed
@adamw
Copy link
Member

adamw commented Feb 25, 2025

Thanks

@som-snytt som-snytt deleted the upgrade/3.3.5 branch February 25, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants