Allow MessageGroupId for standard queues #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove validation that prevented MessageGroupId from being used with standard (non-FIFO) queues. This aligns ElasticMQ with AWS SQS's new "fair queues" feature that allows MessageGroupId on standard queues. Fixes softwaremill#1137
There was a problem hiding this comment.
Pull Request Overview
This PR removes validation that prevented MessageGroupId from being used with standard (non-FIFO) SQS queues, enabling support for AWS SQS's "fair queues" feature. The change aligns ElasticMQ's behavior with AWS SQS's updated functionality.
- Removed validation check that rejected MessageGroupId on standard queues
- Updated validation logic and comments to reflect support for both queue types
- Modified test suite to verify MessageGroupId works with standard queues
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SendMessageDirectives.scala | Removes FIFO-only restriction for MessageGroupId and updates validation comments |
| AmazonJavaSdkTestSuite.scala | Changes test from expecting rejection to verifying acceptance of MessageGroupId on standard queues |
Comments suppressed due to low confidence (1)
rest/rest-sqs-testing-amazon-java-sdk/src/test/scala/org/elasticmq/rest/sqs/AmazonJavaSdkTestSuite.scala:451
- The test assertion 'result should not be null' is too weak and doesn't verify the key behavior. Consider asserting that the message was actually sent successfully by checking result.getMessageId or retrieving the message from the queue to verify MessageGroupId was preserved.
result should not be null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove validation that prevented MessageGroupId from being used with standard (non-FIFO) queues. This aligns ElasticMQ with AWS SQS's new "fair queues" feature that allows MessageGroupId on standard queues.
Fixes #1137