new setup for custom processor #562
Conversation
| target_sources(${CMAKE_PROJECT_NAME} PRIVATE | ||
| ${ROOT}/shared/NativeAudioProcessingModule.cpp | ||
| ${ROOT}/shared/MyProcessorNode.cpp | ||
| ${ROOT}/shared/MyProcessorNodeHostObject.cpp | ||
| ) |
There was a problem hiding this comment.
I used highlight to indicate changes when comparing with generated files, I think it could be misleading if I would highlight only this part. Also highlighting whole file is a no go for me.
| } | ||
| const oscillator = audioContextRef.current.createOscillator(); | ||
| // constructor is put in global scope | ||
| const processor = new MyProcessorNode(audioContextRef.current, global.createCustomProcessorNode(audioContextRef.current.context)); |
There was a problem hiding this comment.
hmm, would it make sense to wrap the call to global.create in a function exported somewhere? :)
import { createCustomProcessorNode } from './creator';
const processor = createCustomProcessorNode(audioContextRef.current);There was a problem hiding this comment.
Also you're using most of the nodes through useRef, while the processor is used directly, either do not use the refs at all or use it for the processor too. (The first option is preferred)
There was a problem hiding this comment.
I agree with a wrapper, but for the sake of simplicity and minimal code example, would this be needed? To me it would introduce unnecessary overhead.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mdydek
force-pushed
the
feat/arch-for-custom-processor
branch
from
1f6af72 to
7bc81ca
Compare
This comment has been minimized.
This comment has been minimized.
packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioContextHostObject.h
Outdated
Show resolved
Hide resolved
packages/custom-node-generator/templates/basic/shared/NativeAudioProcessingModule.cpp
Show resolved
Hide resolved
Closes RNAA-173, RNAA-138, RNAA-175
Introduced changes
Checklist