-
Notifications
You must be signed in to change notification settings - Fork 36
Error handler trait #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Error handler trait #428
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
18c7a0d
Add LexErrorHandler trait
ratmice 0094145
call on_lex_build_error
ratmice 3b19759
call missing_in_lexer/missing_in_parser
ratmice 70129af
Add GrammarErrorHandler
ratmice 59fe0d9
call on_grammar_warning/on_grammar_error
ratmice 874ee01
call on_unexpected_conflicts
ratmice 122dba3
use normal slices rather than boxed slices.
ratmice 75f6528
Document traits
ratmice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing missing here is that warnings are no longer printed, but there is no mechanism to print them from the trait.
there is also the
show_warnings
flag ofCTParserBuilder
we need to add if traits should print warnings.One thing to consider is that we could change the
Ok(())
value ofresults()
to return formatted warnings,CTParserBuilder
then just prints them out tostderr
, or perhaps someemit_warnings()
call?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trait doesn't mind if you print or don't :) I have a couple of possible ideas here:
CTBuilder
s is that they print warnings and/or panic pretty much as they do now.Of these, 1) is the easiest to implement and to get right, so I'm inclined to start there, assuming we think it makes sense!