Skip to content

Correct spend source naming #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2024
Merged

Correct spend source naming #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a34d42
Correct spend source naming
agnessnowplow May 13, 2024
684b519
Correct conversion source defaults
agnessnowplow May 13, 2024
f0a54da
Change spend source defaults
agnessnowplow May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/JsonSchemaValidator/Schemas/dbtAttribution_0.1.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"title": "Conversions Source",
"description": "Source of conversion events",
"longDescription": "The source (schema and table) of your conversion events, likely your atomic events table.",
"packageDefault": "{{ source('atomic', 'events') }}",
"packageDefault": "{{ source('derived', 'snowplow_unified_conversions') }}",
"group": "Warehouse and Tracker"
},
"snowplow__conversion_path_source": {
Expand Down Expand Up @@ -278,11 +278,11 @@
"recommendFullRefresh": true,
"order": 124,
"consoleGroup": "advanced",
"title": "Conversions Source",
"title": "Spend Source",
"description": "Source of marketing spend table",
"longDescription": "The source (schema and table) of your marketing spend source. Optional, needed for the ROAS calculation of the snowplow_attribution_overview. Should be changed to a table reference with `spend` by `channel` and/or `campaign` by `spend_tstamp` (which denotes a timestamp field) information.",
"type": "string",
"packageDefault": "{{ source('atomic', 'events') }}",
"packageDefault": "not defined",
"group": "Warehouse and Tracker"
},
"snowplow__conversion_stitching": {
Expand Down
6 changes: 3 additions & 3 deletions src/components/JsonSchemaValidator/Schemas/dbtAttribution_0.2.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"title": "Conversions Source",
"description": "Source of conversion events",
"longDescription": "The source (schema and table) of your conversion events, likely your atomic events table.",
"packageDefault": "{{ source('atomic', 'events') }}",
"packageDefault": "{{ source('derived', 'snowplow_unified_conversions') }}",
"group": "Warehouse and Tracker"
},
"snowplow__conversion_path_source": {
Expand Down Expand Up @@ -278,11 +278,11 @@
"recommendFullRefresh": true,
"order": 124,
"consoleGroup": "advanced",
"title": "Conversions Source",
"title": "Spend Source",
"description": "Source of marketing spend table",
"longDescription": "The source (schema and table) of your marketing spend source. Optional, needed for the ROAS calculation of the snowplow_attribution_overview. Should be changed to a table reference with `spend` by `channel` and/or `campaign` by `spend_tstamp` (which denotes a timestamp field) information.",
"type": "string",
"packageDefault": "{{ source('atomic', 'events') }}",
"packageDefault": "not defined",
"group": "Warehouse and Tracker"
},
"snowplow__conversion_stitching": {
Expand Down