-
Notifications
You must be signed in to change notification settings - Fork 179
SNOW-2041976 Add support for HTTP header customizers #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sfc-gh-rkowalski
wants to merge
5
commits into
master
Choose a base branch
from
SNOW-2041976-support-dynamic-headers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+973
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
0b0f34d
to
9591e42
Compare
sfc-gh-pfus
reviewed
May 12, 2025
src/main/java/net/snowflake/client/core/AttributeEnhancingHttpRequestRetryHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/HeaderCustomizerHttpRequestInterceptor.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/HeaderCustomizerHttpRequestInterceptor.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/HeaderCustomizerHttpRequestInterceptor.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/HeaderCustomizerHttpRequestInterceptor.java
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/HeaderCustomizerHttpRequestInterceptor.java
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/HeaderCustomizerHttpRequestInterceptor.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/HeaderCustomizerHttpRequestInterceptor.java
Outdated
Show resolved
Hide resolved
9edfbb1
to
962910d
Compare
src/main/java/net/snowflake/client/core/HeaderCustomizerHttpRequestInterceptor.java
Outdated
Show resolved
Hide resolved
sfc-gh-pfus
approved these changes
May 20, 2025
src/main/java/net/snowflake/client/core/HeaderCustomizerHttpRequestInterceptor.java
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/HeaderCustomizerHttpRequestInterceptor.java
Outdated
Show resolved
Hide resolved
sfc-gh-pmotacki
approved these changes
May 21, 2025
9f78f53
to
a167893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-2041976
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX:
External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi
(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.