Snow 1915351 network problems retrying2 #2153
Open
+2,388
−631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pmotacki
force-pushed
the
SNOW-1915351-network-problems-retrying2
branch
from
24000c9 to
b1fd8aa
Compare
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-pmotacki
force-pushed
the
SNOW-1915351-network-problems-retrying2
branch
2 times, most recently
from
ede6e57 to
e139120
Compare
sfc-gh-pmotacki
force-pushed
the
SNOW-1915351-network-problems-retrying2
branch
from
ec3de52 to
5c86146
Compare
| // when there are transient network/GS issues | ||
| private long startTimePerRequest; | ||
| // Used to indicate that this is a login/auth request and will be using the new retry strategy. | ||
| boolean isLoginRequest; |
There was a problem hiding this comment.
why not make this private (perhaps even final), when we have public getters/setters?
There was a problem hiding this comment.
Fixed, final, not because we have a setter.
| } | ||
|
|
||
| static long getNewBackoffInMilli( | ||
| public static long getNewBackoffInMilli( |
There was a problem hiding this comment.
Do we want to expose this to the public? Without @SnowflakeJdbcInternalApi?
| * @throws net.snowflake.client.jdbc.SnowflakeSQLException Request timeout Exception or Illegal | ||
| * State Exception i.e. connection is already shutdown etc | ||
| */ | ||
| public static HttpResponseContextDto executeWitRetries( |
There was a problem hiding this comment.
internal api annotation?
| @@ -318,6 +318,10 @@ public static Connection getConnection( | |||
| properties.put("warehouse", params.get("warehouse")); | |||
| properties.put("ssl", params.get("ssl")); | |||
|
|
|||
| // properties.put("useProxy", "true"); | |||
| importMappingFromResources(SCENARIOS_BASE_DIR + "/response503.json"); | ||
| Properties props = new Properties(); | ||
| props.setProperty("maxHttpRetries", "3"); | ||
| // WireMock.setScenarioState("malformed_response_retry", "MALFORMED_RETRY_3"); |
|
|
||
| // max backoff in milli before we retry due to transient issues | ||
| // we double the backoff after each retry till we reach the max backoff | ||
| // private static final long maxBackoff= 16000; |
| @SnowflakeJdbcInternalApi | ||
| public class HttpExecutingContext { | ||
|
|
||
| // min backoff in milli before we retry due to transient issues |
There was a problem hiding this comment.
In the other parts of the code you used ...Milliseconds suffix for values in milliseconds. Names without it meant values in seconds. Should we use such convention here as well and maybe include such explanation somewhere in comments?
sfc-gh-pmotacki
force-pushed
the
SNOW-1915351-network-problems-retrying2
branch
from
338f1ae to
b979ef1
Compare
sfc-gh-pmotacki
force-pushed
the
SNOW-1915351-network-problems-retrying2
branch
from
b979ef1 to
8dd554c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-XXXXX
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.