-
Notifications
You must be signed in to change notification settings - Fork 178
SNOW-1947501 Support AST Request Internally #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
981935c
to
70112d0
Compare
884d9b3
to
0a2694d
Compare
src/main/java/net/snowflake/client/jdbc/SnowflakePreparedStatementV1.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakePreparedStatementV1.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeStatementV1.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeStatementV1.java
Outdated
Show resolved
Hide resolved
0a2694d
to
7442fcc
Compare
e9a2d72
to
e683552
Compare
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
e683552
to
f5c66d8
Compare
@sfc-gh-pmotacki the failed tests seems like unrelated to my PR. |
props.put("warehouse", "regress"); | ||
props.put("db", "test"); | ||
props.put("schema", "public"); | ||
props.put("ssl", "off"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It couldn't work this way on our CI.
The driver is tested in two environments:
- GA testing on existing Snowflake prod - can be skipped by annotation @DontRunOnGithubActions
- Jenkins testing on Snowflake prepared for tests based on one of the stable branches (It is bptp-stable if I remember correctly) - can be skipped by annotation @DontRunOnJenkins.
Is the feature available in any of these environments? If not, you can test only using wire mock mocked responses; please take a look at BaseWiremockTest.java.
|
||
String url = "jdbc:snowflake://snowflake.reg.local:53200"; | ||
|
||
try (SnowflakeConnectionV1 conn = new SnowflakeConnectionV1(url, props)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The connection should be built based on env variables provided on any test environment. There is a method ready to use for that: BaseJDBCTest.getConnection()
Overview
SNOW-1947501 Support AST Request Internally
Support of dataframe AST request in JDBC. It is an internal feature and used by Snowpark client only.
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX:
External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi
(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.