Skip to content

SNOW-1947501 Support AST Request Internally #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-bli
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli commented Feb 27, 2025

Overview

SNOW-1947501 Support AST Request Internally

Support of dataframe AST request in JDBC. It is an internal feature and used by Snowpark client only.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-bli sfc-gh-bli changed the title [DNM] Dataframe AST POC SNOW-1947501 Support AST Request Internally Mar 11, 2025
@sfc-gh-bli sfc-gh-bli force-pushed the dataframe_ast_poc branch 2 times, most recently from 884d9b3 to 0a2694d Compare March 12, 2025 20:46
@sfc-gh-bli sfc-gh-bli marked this pull request as ready for review March 12, 2025 20:49
@sfc-gh-bli sfc-gh-bli requested a review from a team as a code owner March 12, 2025 20:49
@sfc-gh-snowflakedb-snyk-sa
Copy link
Contributor

sfc-gh-snowflakedb-snyk-sa commented Mar 21, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-bli
Copy link
Collaborator Author

@sfc-gh-pmotacki the failed tests seems like unrelated to my PR.

props.put("warehouse", "regress");
props.put("db", "test");
props.put("schema", "public");
props.put("ssl", "off");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It couldn't work this way on our CI.
The driver is tested in two environments:

  • GA testing on existing Snowflake prod - can be skipped by annotation @DontRunOnGithubActions
  • Jenkins testing on Snowflake prepared for tests based on one of the stable branches (It is bptp-stable if I remember correctly) - can be skipped by annotation @DontRunOnJenkins.
    Is the feature available in any of these environments? If not, you can test only using wire mock mocked responses; please take a look at BaseWiremockTest.java.


String url = "jdbc:snowflake://snowflake.reg.local:53200";

try (SnowflakeConnectionV1 conn = new SnowflakeConnectionV1(url, props)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connection should be built based on env variables provided on any test environment. There is a method ready to use for that: BaseJDBCTest.getConnection()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants