Skip to content

added user email upn data in request session #364 #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

added user email upn data in request session #364 #365

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d7a1958
added user email upn data in request session #364
Mar 31, 2025
3e0d886
removed whitespace from line 431 as per Lint Test #364
Mar 31, 2025
fc473c8
removed whitespace from line 431 as per Lint Test #364
Mar 31, 2025
b11e3f6
removed space from comment from line 424 as per Lint Test #364
Mar 31, 2025
690c801
added hook for saving email via username_claim in request session #364
Apr 3, 2025
e586618
added new line at end in signals.py as per linting test #364
Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions django_auth_adfs/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,15 @@ def authenticate(self, request=None, authorization_code=None, **kwargs):

adfs_response = self.exchange_auth_code(authorization_code, request)
access_token = adfs_response["access_token"]

# Extract claims before user lookup
claims = self.validate_access_token(access_token)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you're not overriding validate_access_token in your code to achieve the logic you want?


# Store claims in session so it's available in login_failed()
if request and hasattr(request, "session"):
username_claim = settings.USERNAME_CLAIM
request.session["username_claim"] = claims[username_claim]

user = self.process_access_token(access_token, adfs_response)
return user

Expand Down
Loading