-
Notifications
You must be signed in to change notification settings - Fork 3
docs: better explain where to take the benchmark names from #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe comment for the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
config/config.yaml (2)
19-21
: Consistent capitalization in comments
The surrounding comments start with an uppercase letter. For consistency, update these lines to capitalize the first word.- # benchmark to use - # see benchmarks in https://github.com/snakemake-workflows/dna-seq-benchmark/blob/main/workflow/resources/presets.yaml - # or any custom benchmark name provided below under custom-benchmarks + # Benchmark to use + # See benchmarks in https://github.com/snakemake-workflows/dna-seq-benchmark/blob/main/workflow/resources/presets.yaml + # Or any custom benchmark name provided below under `custom-benchmarks`
20-20
: Consider pinning or raw-linking the presets URL
Linking to the HTML view can change; using a raw file URL or referencing a specific commit/tag makes this more stable.- # See benchmarks in https://github.com/snakemake-workflows/dna-seq-benchmark/blob/main/workflow/resources/presets.yaml + # See benchmarks in https://raw.githubusercontent.com/snakemake-workflows/dna-seq-benchmark/main/workflow/resources/presets.yaml
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/config.yaml
(1 hunks)
🔇 Additional comments (1)
config/config.yaml (1)
22-22
: ```shell
#!/bin/bashSearch for the benchmark key anywhere in the presets file (case-sensitive)
curl -s https://raw.githubusercontent.com/snakemake-workflows/dna-seq-benchmark/main/workflow/resources/presets.yaml
| grep -n 'giab-na12878-exome'</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Summary by CodeRabbit
benchmark
field to clarify available benchmark sources and provide a helpful reference link for users.