Support selectable auth schemes #4203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
reviewed
Jul 10, 2025
aws/rust-runtime/aws-config/src/default_provider/auth_scheme_preference.rs
Outdated
Show resolved
Hide resolved
ysaito1001
commented
Jul 10, 2025
...kotlin/software/amazon/smithy/rust/codegen/client/smithy/auth/AuthSchemeResolverGenerator.kt
Outdated
Show resolved
Hide resolved
This reverts commit 842ee41.
landonxjames
approved these changes
Jul 11, 2025
aws/rust-runtime/aws-config/src/default_provider/auth_scheme_preference.rs
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This commit addresses #4203 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
added a commit
that referenced
this pull request
Jul 15, 2025
…4211) ## Motivation and Context This PR is a prerequisite for #4203. # Details PR4203 has updated some of the `AuthSchemeId` string values, which causes the `no_auth` test to fail in the semver hazards check. This happens because the inner string value for `NO_AUTH_SCHEME_ID` has been modified from `no_auth` to `noAuth`. To resolve this, this PR updates the test expectation so that it no longer depends on raw string values. Once this PR is merged and released from `aws-sdk-rust`, PR4203 should pass the semver hazards check successfully. Also the test has been moved to `no_auth.rs` since it is not specific to S3 Express; it was originally placed in `express.rs` because the issue was first discovered while investigating S3 Express behavior. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semver-hazards check failure will be resolved when #4211 is released from
aws-sdk-rustDescription
Add support for auth scheme preference, which allows customers to re-prioritize the order of auth schemes originally determined by the auth scheme resolver. See the changelog where the auth scheme preference can be configured.
Note: The preference list is merely a hint rather than a strict override. Any auth schemes not included in the originally resolved auth schemes will be ignored, and won't be an error.
To support the implementation, a utility method has been added toNowOrLaterto map an inner future.Testing
Those called out in the feature spec:
Alternative Auth ResolutionResolving Auth and CredentialsManual auth schemes configurationChecklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.