-
Notifications
You must be signed in to change notification settings - Fork 213
Fix Rust 1.82 compilation errors by upgrading PyO3 from 0.18 to 0.20 #4146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
26d68fb
to
2ab329d
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the code changes, did executing below from smithy-rs/rust-runtime
work fine (or maybe reduced error messages)?
RUSTDOCFLAGS='--cfg docsrs -Dwarnings' cargo +nightly-2025-05-04 doc --no-deps --document-private-items --all-features
which was this incantation that led to the original issue
pyo3-asyncio is now https://crates.io/crates/pyo3-async-runtimes (the new crate is by the author of pyo3, the previous crate had a different author), you can update to that |
We'll handle the migration to I've created a separate issue to track this upgrade: #4152 |
Yes - this PR addresses all the Python-related errors. I intentionally kept these fixes separate from the other work in PR #4125 to maintain clearer change boundaries. Once this PR is merged, PR #4125 should be able to resolve the remaining warnings. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
Went ahead and merged this since I am working on the next MSRV bump in #4154 and wanted to clear out these errors |
PyO3 Upgrade to Fix Compatibility with Rust 1.82
This PR addresses a compatibility issue between
PyO3 0.18
andRust 1.82
, which causes compilation errors due to unexpectedcfg
condition names.When compiled with Rust 1.82, the current PyO3 0.18 dependency produces errors like:
This error occurs because of changes in how Rust handles conditional configuration checks in newer compiler versions.
Changes in this PR:
This upgrade ensures compatibility with Rust 1.82 while maintaining all existing functionality.
Testing