Rfc30/various fixes #2594
Rfc30/various fixes #2594
Conversation
* impl/refactor documet * impl serde/desr for document * fix * add anchor end * precommit fix
* add serde under aws_sdk_unstable * changelog.next.toml * Apply suggestions from code review Co-authored-by: Julian Antonielli <julianantonielli@gmail.com> Co-authored-by: Julian Antonielli <julianantonielli@gmail.com> Co-authored-by: Zelda Hessler <zhessler@amazon.com>
* rfc30 blob * blob import fix add license header pre commit * change unstable keyword to aws_sdk_unstable * change unstable keyword to aws_sdk_unstable * add test * updater changelog * Update CHANGELOG.next.toml * Update lib.rs remove extra Document declaration from bad merge * remove/unused import Co-authored-by: Zelda Hessler <zhessler@amazon.com> Co-authored-by: Zelda Hessler <zelda.hessler@pm.me>
* serde support for datetime with testing * add ciborium to cargo.toml * update changelog * refactor impl suggestions from * refacotring better err message * Revert "update changelog" This reverts commit d58abfa. * add/license header * add: license header * remove unnecessary returns Co-authored-by: Zelda Hessler <zelda.hessler@pm.me>
* fn set_fields * add fn set_fields to fluent builder * better docs * fix * improve document cfg to Attribute class
* add CfgUnstable for feature-gate * add features * add feature-gate * strings for feature gate * Revert "strings for feature gate" This reverts commit 1f33a5c. * Update codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/RuntimeType.kt Co-authored-by: Zelda Hessler <zelda.hessler@pm.me> * fix dependency thing on cargo * add OutputShape to builder * EnumGenerator * StructureGenerator * UnionGenerator * todo * fixed? * SerdeDecorator * codegen stuff * update * fix * Apply suggestions from code review Co-authored-by: Zelda Hessler <zelda.hessler@pm.me> * - refactoring - pre-commit - https://github.com/awslabs/smithy-rs/pull/2183/files#r1080594621 * adds serde-serialize/deserialize * this one causes null pointer exception * interim solution * new push * fix * add Sensitive Warning * add test for CargoTomlGeneratorTest pre-commit fix * Update codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/BuilderGenerator.kt Co-authored-by: Zelda Hessler <zelda.hessler@pm.me> --------- Co-authored-by: Zelda Hessler <zelda.hessler@pm.me>
This reverts commit 6f00505.
thomas-k-cameron
requested review from
david-perez,
drganjoo and
unexge
and removed request for
a team
|
It seems like there are some issues with the server side python binding. I'm not quite sure where it's coming from since I never touched the server side code. @Velfi |
I'm not sure, but I'd assume it has to do with a bad merge/messed up git history. I won't have time to dig in any time soon. You'd likely get farther, faster moving your work into your fork so that you aren't dependent on us for merges. We (as a team) don't currently have the time to give such large PRs the appropriate review. |
|
Gotcha. Changes my PR has mostly comes from the main branch. (I wanted to reflect the latest changes.) Let me figure out a way to make things smaller. |
thomas-k-cameron
force-pushed
the
RFC30/various-fixes
branch
from
9a17ac5 to
d465bb4
Compare
thomas-k-cameron
force-pushed
the
RFC30/various-fixes
branch
from
d465bb4 to
deb7360
Compare
|
If you merge them directly to I will try and re-organize my PRs. Does it work? |
|
Closed in favour of #2615 |
Motivation and Context
This PR implements RFC30.
Description
@streaming bytesfieldserde(skip)is used.Checklist
NA
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.