Skip to content

Commit 6e0f418

Browse files
Merge smithy-rs-release-1.x.y into main (#3708)
2 parents 21b3995 + ae2882d commit 6e0f418

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,17 @@
11
<!-- Do not manually edit this file. Use the `changelogger` tool. -->
2+
June 19th, 2024
3+
===============
4+
**Breaking Changes:**
5+
- :bug::warning: (server, [smithy-rs#3690](https://github.com/smithy-lang/smithy-rs/issues/3690)) Fix request `Content-Type` header checking
6+
7+
Two bugs related to how servers were checking the `Content-Type` header in incoming requests have been fixed:
8+
9+
1. `Content-Type` header checking was incorrectly succeeding when no `Content-Type` header was present but one was expected.
10+
2. When a shape was @httpPayload`-bound, `Content-Type` header checking occurred even when no payload was being sent. In this case it is not necessary to check the header, since there is no content.
11+
12+
This is a breaking change in that servers are now stricter at enforcing the expected `Content-Type` header is being sent by the client in general, and laxer when the shape is bound with `@httpPayload`.
13+
14+
215
June 17th, 2024
316
===============
417

CHANGELOG.next.toml

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,4 @@
99
# message = "Fix typos in module documentation for generated crates"
1010
# references = ["smithy-rs#920"]
1111
# meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client | server | all"}
12-
# author = "rcoh"
13-
[[smithy-rs]]
14-
message = """Fix request `Content-Type` header checking
15-
16-
Two bugs related to how servers were checking the `Content-Type` header in incoming requests have been fixed:
17-
18-
1. `Content-Type` header checking was incorrectly succeeding when no `Content-Type` header was present but one was expected.
19-
2. When a shape was @httpPayload`-bound, `Content-Type` header checking occurred even when no payload was being sent. In this case it is not necessary to check the header, since there is no content.
20-
21-
This is a breaking change in that servers are now stricter at enforcing the expected `Content-Type` header is being sent by the client in general, and laxer when the shape is bound with `@httpPayload`.
22-
"""
23-
references = ["smithy-rs#3690"]
24-
meta = { "breaking" = true, "tada" = false, "bug" = true, "target" = "server"}
25-
author = "david-perez"
12+
# author = "rcoh"

aws/SDK_CHANGELOG.next.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"smithy-rs#3673"
1919
],
2020
"since-commit": "052b4dadc06354e673f6a642487871d5f50d135a",
21-
"age": 3
21+
"age": 4
2222
},
2323
{
2424
"message": "Fix S3 ListParts API paginator infinite loop.",
@@ -32,7 +32,7 @@
3232
"aws-sdk-rust#1143"
3333
],
3434
"since-commit": "052b4dadc06354e673f6a642487871d5f50d135a",
35-
"age": 3
35+
"age": 4
3636
},
3737
{
3838
"message": "Stalled stream protection will no longer be applied to the following Lambda operations: [Invoke], [InvokeAsync], [InvokeWithResponseStream].\n\n[Invoke]: https://docs.rs/aws-sdk-lambda/latest/aws_sdk_lambda/client/struct.Client.html#method.invoke\n[InvokeAsync]: https://docs.rs/aws-sdk-lambda/latest/aws_sdk_lambda/client/struct.Client.html#method.invoke_async\n[InvokeWithResponseStream]: https://docs.rs/aws-sdk-lambda/latest/aws_sdk_lambda/client/struct.Client.html#method.invoke_with_response_stream\n",
@@ -47,7 +47,7 @@
4747
"smithy-rs#3639"
4848
],
4949
"since-commit": "57ed310e6d21041eb36d825c50032295eef0b630",
50-
"age": 1
50+
"age": 2
5151
},
5252
{
5353
"message": "Add documentation on the default configuration to `from_env`, `load_from_env`, `defaults`, and `load_from_defaults` in the `aws-config` crate.",
@@ -61,7 +61,7 @@
6161
"aws-sdk-rust#1162"
6262
],
6363
"since-commit": "57ed310e6d21041eb36d825c50032295eef0b630",
64-
"age": 1
64+
"age": 2
6565
},
6666
{
6767
"message": "Pre-signed requests may now be converted to Http v1.x requests. This requires enabling the `http-1x` feature for the SDK in question.\nThen, call `PresignedRequest::make_http_1x_request` or `PresignedRequest::into_http_1x_request`.\n",
@@ -75,7 +75,7 @@
7575
"smithy-rs#3696"
7676
],
7777
"since-commit": "57ed310e6d21041eb36d825c50032295eef0b630",
78-
"age": 1
78+
"age": 2
7979
},
8080
{
8181
"message": "`AwsErrorCodeClassifier` for S3 now treats `InternalError` as a transient error to trigger retries.",
@@ -89,7 +89,7 @@
8989
"aws-sdk-rust#1163"
9090
],
9191
"since-commit": "57ed310e6d21041eb36d825c50032295eef0b630",
92-
"age": 1
92+
"age": 2
9393
}
9494
],
9595
"aws-sdk-model": []

0 commit comments

Comments
 (0)