Skip to content

Conversation

@trishorts
Copy link
Contributor

@trishorts trishorts commented Oct 25, 2025

the existing method for evaluating if a sequence variant is valid just isn't up to snuf. This PR adds improved bool for AreValid that considers all changes at the sequence and modification level of a variant

@trishorts trishorts changed the title Sequence variation valid Update Handling of Sequence Variants (Part 6): SequenceVariant AreValid Oct 25, 2025
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

❌ Patch coverage is 69.58175% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.87%. Comparing base (57f1327) to head (5cac61f).

Files with missing lines Patch % Lines
mzLib/Omics/BioPolymer/SequenceVariation.cs 56.75% 22 Missing and 10 partials ⚠️
mzLib/Omics/BioPolymer/VariantApplication.cs 64.19% 20 Missing and 9 partials ⚠️
mzLib/UsefulProteomicsDatabases/ProteinXmlEntry.cs 88.54% 7 Missing and 4 partials ⚠️
...Databases/DecoyGeneration/DecoyProteinGenerator.cs 12.50% 0 Missing and 7 partials ⚠️
...micsDatabases/DecoyGeneration/RnaDecoyGenerator.cs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
- Coverage   81.00%   80.87%   -0.13%     
==========================================
  Files         269      269              
  Lines       38826    38957     +131     
  Branches     4241     4272      +31     
==========================================
+ Hits        31450    31508      +58     
- Misses       6640     6692      +52     
- Partials      736      757      +21     
Files with missing lines Coverage Δ
mzLib/Omics/BioPolymer/VariantCallFormat.cs 86.95% <ø> (ø)
mzLib/UsefulProteomicsDatabases/ProteinDbWriter.cs 95.48% <100.00%> (ø)
...micsDatabases/DecoyGeneration/RnaDecoyGenerator.cs 83.72% <50.00%> (ø)
...Databases/DecoyGeneration/DecoyProteinGenerator.cs 90.79% <12.50%> (ø)
mzLib/UsefulProteomicsDatabases/ProteinXmlEntry.cs 96.78% <88.54%> (-2.75%) ⬇️
mzLib/Omics/BioPolymer/VariantApplication.cs 79.37% <64.19%> (-2.40%) ⬇️
mzLib/Omics/BioPolymer/SequenceVariation.cs 66.93% <56.75%> (-19.03%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant