-
Notifications
You must be signed in to change notification settings - Fork 38
Edited MSFragger Reader #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mzhastings
wants to merge
21
commits into
smith-chem-wisc:master
Choose a base branch
from
mzhastings:fixMI
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue where psmtsv files w/o PEP info couldn't be read in
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #871 +/- ##
=======================================
Coverage 78.67% 78.68%
=======================================
Files 251 251
Lines 36330 36331 +1
Branches 3873 3875 +2
=======================================
+ Hits 28584 28586 +2
Misses 7082 7082
+ Partials 664 663 -1
🚀 New features to boost your workflow:
|
Alexander-Sol
requested changes
Apr 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can get rid of the SmallCalibratibleYeast.mzml file, as it's not actually used for the tests
Alexander-Sol
previously approved these changes
Jun 9, 2025
nbollis
requested changes
Jun 9, 2025
trishorts
previously approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to MSFraggerPsm class to fix errors when reading psm.tsv files returned by MSFragger.
Made changes to SpectrumMatchFromTsv class