Skip to content

Conversation

@mzhastings
Copy link
Contributor

@mzhastings mzhastings commented Apr 22, 2025

Made changes to MSFraggerPsm class to fix errors when reading psm.tsv files returned by MSFragger.

  • Added a new property RetentionTimeSeconds to map the raw "Retention" column from the psm.tsv file (reported in seconds).
  • Modified the existing RetentionTime property to be computed from RetentionTimeSeconds, converting it to minutes
  • Changed FileName property to use FileNameWithoutExtension instead of SpectrumFilePath (points to a .pep.xml file created by MSFragger, which appends the file name with interact-). The list of SpectrumFilePaths was thus inconsistent with the raw file names used in the dictionary mapping file names to their paths

Made changes to SpectrumMatchFromTsv class

  • Added support for optional PEP and PEP_QValue columns for compatibility with different versions of MetaMorpheus that may or may not include these columns

@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (b83de70) to head (eb33927).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #871   +/-   ##
=======================================
  Coverage   78.67%   78.68%           
=======================================
  Files         251      251           
  Lines       36330    36331    +1     
  Branches     3873     3875    +2     
=======================================
+ Hits        28584    28586    +2     
  Misses       7082     7082           
+ Partials      664      663    -1     
Files with missing lines Coverage Δ
...nalResults/IndividualResultRecords/MsFraggerPsm.cs 91.13% <100.00%> (+0.11%) ⬆️
...ts/IndividualResultRecords/SpectrumMatchFromTsv.cs 92.94% <100.00%> (+0.24%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Alexander-Sol Alexander-Sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get rid of the SmallCalibratibleYeast.mzml file, as it's not actually used for the tests

Alexander-Sol
Alexander-Sol previously approved these changes Jun 9, 2025
trishorts
trishorts previously approved these changes Jun 10, 2025
@mzhastings mzhastings dismissed stale reviews from trishorts and Alexander-Sol via 2c43eb0 June 17, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants