Skip to content

Make iOS networking methods async #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Make iOS networking methods async #80

merged 5 commits into from
Jun 19, 2024

Conversation

vanshg
Copy link
Contributor

@vanshg vanshg commented Jun 15, 2024

Story: https://app.shortcut.com/smileid/story/12926

Summary

Updates networking methods to use asynchronous Swift code

Known Issues

This can go in once smileidentity/ios#183 is released

Test Instructions

Run jobs from the Flutter sample app

@vanshg vanshg requested a review from a team as a code owner June 15, 2024 00:57
@vanshg vanshg requested a review from tobitech June 19, 2024 00:20
@vanshg vanshg requested a review from tobitech June 19, 2024 14:19
Copy link
Contributor

@tobitech tobitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vanshg vanshg merged commit 17dd784 into main Jun 19, 2024
4 checks passed
@vanshg vanshg deleted the ios-async branch June 19, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants