Skip to content

Made SVM multiclass #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

DanielLacina
Copy link
Contributor

I split the SVM classification into multiple binary classifications using the one for all strategy.

@DanielLacina DanielLacina requested a review from Mec-iS as a code owner June 3, 2025 16:06
@DanielLacina
Copy link
Contributor Author

I probably messed a ton of things up. Im new to open source.

@DanielLacina
Copy link
Contributor Author

Out of 50-100 iterations of random sampling, the lowest accuracy score on the test set was 0.8666667

@DanielLacina
Copy link
Contributor Author

It's extremely slow relative to scikit-learn though

@Mec-iS
Copy link
Collaborator

Mec-iS commented Jun 3, 2025

Thank you! I will have time to take a look at this later this week or next week 🌈

@DanielLacina
Copy link
Contributor Author

Alright. Appreciate you notifying me.

@Mec-iS
Copy link
Collaborator

Mec-iS commented Jun 3, 2025

np. I have enabled the tests runners in the meanwhile.

@DanielLacina
Copy link
Contributor Author

Ima fix the test issues with this PR and then work on other issues.

@Mec-iS
Copy link
Collaborator

Mec-iS commented Jun 3, 2025

Something to start from:

Please measure performance before and after the change. See the workbenches https://github.com/smartcorelib/smartcore-benches
you can add a bench with the thing you are working on.

to use an array in smartcore you need to use the provided zero-copy structures like Array1 and Array2, not Vec. For example at line 152: Array1<TY> should become Array2<TY>

@Mec-iS Mec-iS mentioned this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants