Skip to content

Implement SVR and SVR kernels with Enum. Add tests for argsort_mut #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 2, 2025

Conversation

Mec-iS
Copy link
Collaborator

@Mec-iS Mec-iS commented Jun 1, 2025

Fixes #301 WONTFIX because of what is explained in the issue's comment

Fixes #304 see commit below

Prepare for release v0.4.2

Checklist

  • My branch is up-to-date with development branch.
  • Everything works and tested on latest stable Rust.
  • Coverage and Linting have been applied

Current behaviour

  • Implement SVR kernels as enumerator
  • basic svr and svr_params implementation
  • Implement search grid for SVR. Add documentation.
  • Fix serde configuration in cargo clippy
  • Add tests for sorting and add type to stack variable parameter

Changes

  • BREAKING CHANGES: the interface for defining kernels is slightly changed. See tests in the src/svm/mod.rs module.

@Mec-iS Mec-iS requested a review from morenol June 1, 2025 11:34
Copy link

codecov bot commented Jun 1, 2025

Codecov Report

Attention: Patch coverage is 64.70588% with 24 lines in your changes missing coverage. Please review.

Project coverage is 46.21%. Comparing base (239c004) to head (29049af).
Report is 7 commits behind head on development.

Files with missing lines Patch % Lines
src/svm/mod.rs 57.14% 12 Missing ⚠️
src/svm/search/svr_params.rs 75.00% 9 Missing ⚠️
src/svm/svr.rs 0.00% 2 Missing ⚠️
src/linalg/basic/arrays.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #303      +/-   ##
===============================================
+ Coverage        45.49%   46.21%   +0.71%     
===============================================
  Files               85       86       +1     
  Lines             7254     7390     +136     
===============================================
+ Hits              3300     3415     +115     
- Misses            3954     3975      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mec-iS Mec-iS changed the title Add tests for argsort_mut Implement SVR and SVR kernels with Enum. Add tests for argsort_mut Jun 1, 2025
@Mec-iS Mec-iS merged commit 4442480 into development Jun 2, 2025
11 checks passed
@Mec-iS Mec-iS deleted the issue-301-add-minor-tests branch June 2, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panics: index out of bounds when using tokio runtime
1 participant