fix: avoid requiring all executors for predecessors calculation #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
🦋 Changeset detectedLatest commit: aed4de9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 ecPablo, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
ChrisAmora
previously approved these changes
Aug 26, 2025
gustavogama-cll
previously approved these changes
Aug 26, 2025
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
ecPablo
dismissed stale reviews from gustavogama-cll and ChrisAmora
via
7aa2499
gustavogama-cll
approved these changes
Aug 26, 2025
ChrisAmora
approved these changes
Aug 26, 2025
|
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/mcms@0.22.0 ### Minor Changes - [#441](#441) [`fdf66b3`](fdf66b3) Thanks [@ecPablo](https://github.com/ecPablo)! - Adds support for getMinDelay to timelock inspectors on all supported chain families - [#446](#446) [`2e56b50`](2e56b50) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - feat: implement TimelockProposal.Merge() - [#450](#450) [`6e542cb`](6e542cb) Thanks [@ecPablo](https://github.com/ecPablo)! - feat: add converted operations count function ### Patch Changes - [#449](#449) [`8f14da3`](8f14da3) Thanks [@ecPablo](https://github.com/ecPablo)! - fix: avoid requiring all executors for converters generation Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue in the converters generation logic for timelock executables. The main change ensures that converters are generated based on the proposal's chain metadata rather than requiring all executors, this is specially useful on the mcms cli in CLD where we need to sometimes load a subset of the chain selectors only so not all executables are provided.