feat: add support for get min delay [DX-1583] #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
🦋 Changeset detectedLatest commit: 08dcba8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
ecPablo
changed the title
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
|
There was a problem hiding this comment.
what's wrong with using := for the variable initializations? Is the linter complaining?
There was a problem hiding this comment.
yeah the linter was complaining about it, not super fan of the rule though
gustavogama-cll
approved these changes
Aug 18, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/mcms@0.22.0 ### Minor Changes - [#441](#441) [`fdf66b3`](fdf66b3) Thanks [@ecPablo](https://github.com/ecPablo)! - Adds support for getMinDelay to timelock inspectors on all supported chain families - [#446](#446) [`2e56b50`](2e56b50) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - feat: implement TimelockProposal.Merge() - [#450](#450) [`6e542cb`](6e542cb) Thanks [@ecPablo](https://github.com/ecPablo)! - feat: add converted operations count function ### Patch Changes - [#449](#449) [`8f14da3`](8f14da3) Thanks [@ecPablo](https://github.com/ecPablo)! - fix: avoid requiring all executors for converters generation Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for get min delay on all supported mcms chains. This call is might be useful in fork testing contexts, where we need to know the time we need to wait or skip on the forked chain before we can execute a timelock operation.
AI Summary
This pull request adds support for retrieving the minimum delay (
getMinDelay) from timelock contracts across all supported chain families (EVM, Aptos, Solana). It introduces theGetMinDelaymethod to theTimelockInspectorinterface and implements it for each chain, along with corresponding tests and mocks. The change ensures that users and tests can query the configured minimum delay for timelock operations in a unified way.Cross-chain Timelock Inspector Enhancements
Interface and Implementation:
GetMinDelay(ctx, address)to theTimelockInspectorinterface insdk/timelock_inspector.go, and implemented this method for EVM (sdk/evm/timelock_inspector.go), Aptos (sdk/aptos/timelock_inspector.go), and Solana (sdk/solana/timelock_inspector.go). This allows querying the minimum delay for timelock contracts on all supported chains. [1] [2] [3] [4]End-to-End and Unit Testing:
GetMinDelayin EVM (sdk/evm/timelock_inspector_test.go), Aptos (e2e/tests/aptos/timelock_proposal.go), Solana (e2e/tests/solana/timelock_inspection.go), and EVM e2e suite (e2e/tests/evm/timelock_inspection.go). These verify correct functionality and error handling. [1] [2] [3] [4]Mocks and Test Infrastructure:
TimelockInspectorandTimelockExecutorto support the newGetMinDelaymethod, enabling robust unit testing and test isolation. [1] [2]Refactoring and Code Quality:
Documentation and Release Note:
@smartcontractkit/mcms, indicating minor version bump and summarizing the addition ofgetMinDelaysupport. (.changeset/giant-plums-dress.md)