Skip to content

Adds LibreCapital nav EA #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 15, 2025
Merged

Adds LibreCapital nav EA #3924

merged 8 commits into from
Jul 15, 2025

Conversation

mohamed-mehany
Copy link
Collaborator

@mohamed-mehany mohamed-mehany commented Jul 3, 2025

Closes DF-21507

Changes

  • Adds a new external adapter to retrieve and return the latest NAV for a specified LibreCapital fund

Steps to Test

  1. Integration tests
  2. Via local server
    Test payload
POST http://127.0.0.1:8080
{
  "data": {
    "endpoint": "nav",
    "globalFundID": 1234

  }
}

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Jul 3, 2025

🦋 Changeset detected

Latest commit: bc8dbac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/nav-libre-adapter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mohamed-mehany mohamed-mehany changed the title Libre nav consulting Adds LibreCapital nav EA Jul 3, 2025
@mohamed-mehany mohamed-mehany force-pushed the libre-nav-consulting branch from b7f1dbe to d0cd477 Compare July 3, 2025 14:05
@mohamed-mehany mohamed-mehany force-pushed the libre-nav-consulting branch from d0cd477 to 6d76d03 Compare July 3, 2025 14:07
@mohamed-mehany mohamed-mehany force-pushed the libre-nav-consulting branch 4 times, most recently from 2d43231 to debbc45 Compare July 10, 2025 00:24
@mohamed-mehany mohamed-mehany marked this pull request as ready for review July 10, 2025 12:12
@mohamed-mehany mohamed-mehany requested a review from a team July 10, 2025 12:18
@mohamed-mehany mohamed-mehany requested a review from mxiao-cll July 11, 2025 01:31
@mohamed-mehany mohamed-mehany force-pushed the libre-nav-consulting branch 2 times, most recently from 98aff54 to 756f8fd Compare July 11, 2025 01:39
@mohamed-mehany mohamed-mehany requested a review from dskloetc July 15, 2025 10:54
@mmcallister-cll mmcallister-cll merged commit 7e614b5 into main Jul 15, 2025
18 checks passed
@mmcallister-cll mmcallister-cll deleted the libre-nav-consulting branch July 15, 2025 19:12
@github-actions github-actions bot mentioned this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants