Fix remote trigger event expiry logic #17775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolekk
force-pushed
the
bugfix/remote_trigger_expiry
branch
from
2072e10 to
4bed6af
Compare
bolekk
changed the title
bolekk
force-pushed
the
bugfix/remote_trigger_expiry
branch
from
4bed6af to
960fdf2
Compare
krehermann
reviewed
May 19, 2025
krehermann
reviewed
May 19, 2025
krehermann
reviewed
May 19, 2025
krehermann
reviewed
May 19, 2025
krehermann
reviewed
May 19, 2025
krehermann
reviewed
May 19, 2025
krehermann
reviewed
May 19, 2025
bolekk
force-pushed
the
bugfix/remote_trigger_expiry
branch
from
960fdf2 to
75df981
Compare
krehermann
previously approved these changes
May 19, 2025
justinkaseman
previously approved these changes
May 19, 2025
bolekk
force-pushed
the
bugfix/remote_trigger_expiry
branch
from
75df981 to
55ec76c
Compare
justinkaseman
approved these changes
May 20, 2025
|
krehermann
approved these changes
May 20, 2025
This was referenced May 20, 2025
bolekk
added a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each workflow node waits for at least F+1 identical copies of each trigger event before trusting it and starting workflow execution.
Event copies need to be clustered within a relatively short time window (default = 1 minute). Anything received after that is rejected. The problem is that we can't trust the first received event to establish the "creationTs" - if one of them is sent too early, all subsequent ones can be incorrectly rejected.
The proposed fix is to remove the check. We already rely on messageCache.Ready() to apply the time window when aggregating events. That time window is applied backwards after each new event is received so it has the desired effect.