chore: use decred secp256k1 directly #15813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
@cedric-cordenier @ilija42 Hi sir, could you please help me review this PR, thanks for your time~ |
BabyHalimao
force-pushed
the
chore/use-decred-secp-directly
branch
from
aeb4c67 to
26390da
Compare
|
@cedric-cordenier Hi sir, could you please help me review this PR |
BabyHalimao
force-pushed
the
chore/use-decred-secp-directly
branch
from
26390da to
11da855
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #14840 which has already been approved by @ilija42 , but closed by github-actions bot.
Original PR desc:
Use
github.com/decred/dcrd/dcrec/secp256k1/v4directly rather thangithub.com/btcsuite/btcd/btcec/v2which is just a wrapper around the underlying decred library. Inspired by ethereum/go-ethereum#30595github.com/btcsuite/btcd/btcec/v2has a very annoying breaking change when upgrading from v2.3.3 to v2.3.4. The easiest way to work around this is to remove the wrapper.