Skip to content

Conversation

@connorwstein
Copy link
Contributor

@connorwstein connorwstein commented Nov 3, 2025

Will add support for sign/encrypt in a follow up, for now just supporting the admin interface. General approach:

  • CLI as an importable package so the commands can theoretically be embedded in other cobra CLIs if needed (e.g. if core were to ever move).
  • Use json marshaled input/ouput based on the keystore interface existing structs. Easy way to expose batching/API plurality and prevents CLI drift if we add new fields. Support file/stdin input too ("-" for stdin I've seen in kubectl, seems to be relatively standard).
  • Env vars for keystore loading parameters - avoids password in shell history and also avoids including them in every CLI command since they are needed for all

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

✅ API Diff Results - No breaking changes


📄 View full apidiff report

This reverts commit fd1695e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant