Solana CCTP token pool extra-data improved ABI decoding #1099
+66
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 toblich, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
| @@ -14,6 +14,8 @@ impl TokenPoolExtraData { | |||
| const NONCE_INDEXES: (usize, usize) = (24, 32); | |||
| // The source domain is in bytes 60..64 in the serialized data (u32 is 4 bytes) | |||
| const SOURCE_DOMAIN_INDEXES: (usize, usize) = (60, 64); | |||
| // Total size of the serialized data (2 fields of 32 bytes each) | |||
| const TOTAL_SIZE: usize = 64; | |||
|
|
|||
| pub fn abi_encode(&self) -> [u8; 64] { | |||
| let mut bytes = [0u8; 64]; | |||
There was a problem hiding this comment.
Tiny nit: This method could also use TOTAL_SIZE instead of the 64 magic number, if nothing else to signal that they're the same constant (ditto return value)
PabloMansanet
approved these changes
Jul 25, 2025
agusaldasoro
approved these changes
Jul 28, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.