Skip to content

Fix Solana offramp account derivation #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

toblich
Copy link
Contributor

@toblich toblich commented Jul 23, 2025

No description provided.

@toblich toblich requested a review from PabloMansanet July 23, 2025 13:46
@toblich toblich requested a review from a team as a code owner July 23, 2025 13:46
@@ -495,6 +495,7 @@ pub mod cctp_token_pool {
stage: String,
release_or_mint: ReleaseOrMintInV1,
) -> Result<DeriveAccountsResponse> {
msg!("Stage: {}", stage);
Copy link
Contributor

@PabloMansanet PabloMansanet Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this worth keeping now after this has been tested in staging? We might not want to pay the price in CU.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually only used on simulation, so it doesn't really use CUs... I think it's still easier to keep it around, in case we have to debug anything else still, and at pretty much no cost : shrug:

PabloMansanet
PabloMansanet previously approved these changes Jul 25, 2025
Copy link
Contributor

@PabloMansanet PabloMansanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great test coverage, great fixes (nothing stands out as off)

Co-authored-by: PabloMansanet <pablo.mansanet@smartcontract.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants