-
Notifications
You must be signed in to change notification settings - Fork 13
Fix Solana offramp account derivation #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -495,6 +495,7 @@ pub mod cctp_token_pool { | |||
stage: String, | |||
release_or_mint: ReleaseOrMintInV1, | |||
) -> Result<DeriveAccountsResponse> { | |||
msg!("Stage: {}", stage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this worth keeping now after this has been tested in staging? We might not want to pay the price in CU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually only used on simulation, so it doesn't really use CUs... I think it's still easier to keep it around, in case we have to debug anything else still, and at pretty much no cost : shrug:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great test coverage, great fixes (nothing stands out as off)
Co-authored-by: PabloMansanet <pablo.mansanet@smartcontract.com>
No description provided.