Skip to content

Simpler Implementation of CCTP V2 for USDC Token Pool #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

jhweintraub
Copy link
Contributor

This PR presents a simpler implementation of the USDC Token Pool that supports CCTP V2 while enabling V1 legacy pools to also be supported via a pass-through proxy mechanism. This version is much more efficient as it does not require maintaining extremely similar and duplicated methods for V1 and V2 of CCTP.

To accomplish this the USDC Token Pool was updated to work with the V2 functions. If a message is deemed to be sent via V1, it will instead be proxied to the previous token pool and its corresponding message transmitter proxy and executed as such.

@jhweintraub jhweintraub requested a review from a team as a code owner July 7, 2025 18:17
Copy link

github-actions bot commented Jul 7, 2025

👋 jhweintraub, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@jhweintraub jhweintraub changed the title Simpler Implementation of CCTP for USDC Token Pool Simpler Implementation of CCTP V2 for USDC Token Pool Jul 7, 2025
i_token.safeTransferFrom(msg.sender, address(this), amount);
// TODO: Replace with actual Lockbox and not use shitty casting
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

Copy link
Contributor Author

@jhweintraub jhweintraub Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I blame the AI intern for that?

Copy link

Metric feat/cctpv2_simple main
Coverage 70.1% 69.9%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants