CCIP-6264 Removing redundant filter for data word > 0x0 #1050
+102
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecutionStateChange.State > 0 filter was redundant. It was translated to the following filter in the SQL query
That requires an additional index scan to verify whether the state is greater than or equal to 0. However, events with state = 0 must never land in the logs table, because UNTOUCHED(0) is an internal status used by the contract to track the state of the message during TX.
ExecutionStateChange
event must never be emitted with anything other than INPROGRESS(1), SUCCESS(2) or FAILURE(3). Therefore, we can safely assume that extra filtering on the database level is not required. However, to stay defensive, we will add a check that will ignore events containing UNTOUCHED