interface cleanup #1008
Merged
interface cleanup #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensR
force-pushed
the
interface-cleanu.p
branch
from
402813b to
8c04f21
Compare
RensR
force-pushed
the
interface-cleanu.p
branch
from
8c04f21 to
eb451ca
Compare
RensR
force-pushed
the
interface-cleanu.p
branch
from
eb451ca to
88ef8ed
Compare
0xsuryansh
previously approved these changes
Jun 20, 2025
0xsuryansh
reviewed
Jun 20, 2025
| /// On L1 chains like Ethereum or Avax, the only component is the gas price. | ||
| /// On Optimistic Rollups, there are two components - the L2 gas price, and L1 base fee for data availability. | ||
| /// On future chains, there could be more or differing price components. | ||
| /// PriceRegistry does not contain chain-specific logic to parse destination chain price components. |
Member
There was a problem hiding this comment.
0xsuryansh
approved these changes
Jun 20, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the IPriceRegistry functions to IFeeQuoter and removes IPriceRegistry