feat!: add new nlp subcommand, require it for any NLP tasks #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, there isn't much difference between the "etl" and "nlp" subcommands, except that: - all FHIR resource type tasks must use "etl" - all NLP tasks must use "nlp" - completion tracking isn't used for "nlp" In the future, we'll add more NLP-specific options to the "nlp" subcommand, like document selection args and eventually, some sort of dynamic NLP config options. But for right now, this is just a refactor and splitting out those two subcommands.
mikix
force-pushed
the
mikix/add-nlp-command
branch
from
4f12dd1 to
eb3b75e
Compare
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
dogversioning
approved these changes
Aug 18, 2025
| @@ -0,0 +1,30 @@ | |||
| """ | |||
| Similar to a normal ETL task, but with an extra NLP focus. | |||
There was a problem hiding this comment.
nit: it might? be nice to specify a little more how NLP focus differs (i.e. no deid) for a future reader
There was a problem hiding this comment.
Adding this below that line:
Some differences:
- Runs only the NLP targeted tasks
- No completion tracking
- No bulk de-identification (i.e. no MS tool)
- Has NLP specific arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, there isn't much difference between the "etl" and "nlp" subcommands, except that:
In the future, we'll add more NLP-specific options to the "nlp" subcommand, like document selection args and eventually, some sort of dynamic NLP config options. But for right now, this is just a refactor and splitting out those two subcommands.
Checklist
docs/) needs to be updated