docs: update jwks generation commands to separate public/private keys #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
force-pushed
the
mikix/jwks-docs
branch
from
ea48331 to
dcbb853
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
mikix
commented
Dec 30, 2024
There was a problem hiding this comment.
Something changed in the json formatting library that something in our stack uses.
Previously, we were passing python objects to respx to return in mock http responses, then expecting a hardcoded number of bytes back - i.e. baking assumptions about the json encoding that would occur behind the scenes into our tests. Whoops.
So now the tests encode json to text themselves and keep track of the size.
There was a problem hiding this comment.
This was unrelated to the docs change, I'm just using this PR as a convenient place to fix the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
docs/) needs to be updated