Skip to content

A couple small improvements #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

A couple small improvements #362

merged 2 commits into from
Nov 18, 2024

Conversation

@mikix
Copy link
Contributor

@mikix mikix commented Nov 15, 2024 •
edited
Loading

  • Add some extension URLs that Synthea generates to the scrubber's allowlist/blocklist
  • If the completion table can't be written for some reason, at least flag it to the user by marking that something went wrong

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added

@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3607 3546 98% 98% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cumulus_etl/deid/scrubber.py 100% 🟢
cumulus_etl/etl/tasks/base.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 9b4519b by action🐍

@mikix mikix merged commit a2edca0 into main Nov 18, 2024
3 checks passed
@mikix mikix deleted the mikix/tweaks branch November 18, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dogversioning dogversioning dogversioning approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikix @dogversioning