feat: mark data/url fields inside DocRef attachments as absent #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
When we strip the data & url fields from DocumentReferences, we previously just deleted the fields and moved on. But in order to be able to do some QA analysis on whether those fields were provided in the first place, it's nice to have a record of them. So whenever we delete those fields, we also now leave a data-absent extension in place with the value "masked".
mikix
force-pushed
the
mikix/mask-attachments
branch
from
1ca9ac9 to
4b782f2
Compare
dogversioning
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we strip the data & url fields from DocumentReferences, we previously just deleted the fields and moved on.
But in order to be able to do some QA analysis on whether those fields were provided in the first place, it's nice to have a record of them.
So whenever we delete those fields, we also now leave a data-absent extension in place with the value "masked".
Checklist
docs/) needs to be updated