remove asynch module; move SmartLedsWriteAsync to top level #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the last PR I plan to make for now. It'd be nice to get this in and make a 0.4 release so drivers can implement the new async trait. |
|
Ping. Two drivers are waiting on releasing the async trait: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's awkward to have only one of sync and async traits in a submodule. The sync trait could be moved to a submodule, with a
pub usestatement for backwards compatibility. However, as per #19, if there aren't going to be Cargo features for sync & async, then I don't think there's much point having submodules.