ACME Certificate Revocation #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
Checking if this solves the issue with new linting issues that, at least locally, seem to have been introduced between v1.41.0 and latest (v1.43.0).
github-actions
bot
added
the
needs triage
hslatman
changed the title
The logic for both test cases is fairly similar, but with some small differences. Made those clearer by means of some comments. Also added some comments to the middleware logic that decided whether to extract JWK or lookup by KID.
dopey
reviewed
Dec 2, 2021
acme/api/handler.go
Outdated
| extractPayloadByJWK := func(next nextHTTP) nextHTTP { | ||
| return h.baseURLFromRequest(h.lookupProvisioner(h.addNonce(h.addDirLink(h.verifyContentType(h.parseJWS(h.validateJWS(h.extractJWK(h.verifyAndExtractJWSPayload(next))))))))) | ||
| return validatingMiddleware(h.validateJWS(h.extractJWK(h.verifyAndExtractJWSPayload(next)))) |
There was a problem hiding this comment.
should ValidateJWS also be part of validateMiddleware?
There was a problem hiding this comment.
Good point 😅. I have to admit validatingMiddleware is not that great of a name, as it does more than just that, but it works.
Fixed in 004fc05.
dopey
reviewed
Dec 2, 2021
acme/api/revoke.go
Outdated
| } | ||
|
|
||
| // extractIdentifiers extracts ACME identifiers from an x509 certificate and | ||
| // creates a map from them. The map ensures that double SANs are deduplicated. |
dopey
reviewed
Dec 2, 2021
acme/api/revoke.go
Outdated
| } | ||
| result[identifierKey(identifier)] = identifier | ||
| } | ||
| // TODO(hs): should we include the CommonName or not? |
There was a problem hiding this comment.
Seems like we can remove this comment.
github-actions
bot
added
the
needs triage
This was referenced Dec 6, 2021
As discussed in smallstep#767, we opted for not including this authorization flow to prevent users from getting OOMs. We can add the functionality back when the underlying data store can provide access to a long list of Authorizations more efficiently, for example when a callback is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ACME certificate revocation as discussed in #468.
Basic revocation using either JWK or KID works. Needs error handling improvements and tests.