Skip to content

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented Aug 4, 2025

Upgrade github.com/coreos/go-oidc/v3 to v3.15.0.

https://github.com/coreos/go-oidc/releases/tag/v3.15.0 moved signature validation earlier into the process, breaking an existing test case. Changes: coreos/go-oidc@v3.14.1...v3.15.0.

Replaces #2350.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Aug 4, 2025
@hslatman hslatman changed the title Herman/fix OIDC upgrade Upgrade github.com/coreos/go-oidc/v3 to v3.15.0. Aug 4, 2025
@hslatman hslatman added this to the v0.28.5 milestone Aug 4, 2025
@hslatman hslatman requested a review from maraino August 5, 2025 09:46
@hslatman hslatman enabled auto-merge August 5, 2025 10:25
dependabot bot and others added 2 commits August 5, 2025 13:16
Bumps [github.com/coreos/go-oidc/v3](https://github.com/coreos/go-oidc) from 3.14.1 to 3.15.0.
- [Release notes](https://github.com/coreos/go-oidc/releases)
- [Commits](coreos/go-oidc@v3.14.1...v3.15.0)

---
updated-dependencies:
- dependency-name: github.com/coreos/go-oidc/v3
  dependency-version: 3.15.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
In coreos/go-oidc@v3.14.1...v3.15.0, the
JWT signature algorithm verification is moved earlier into the
process, resulting in our existing test failing. The JWT has
algorithm `RS256` set, whereas the verifier had `ES256`. It needs
to have `RS256` to validate the token.
@hslatman hslatman force-pushed the herman/fix-oidc-upgrade branch from 3a9a58e to 2bb1896 Compare August 5, 2025 11:16
@hslatman hslatman merged commit 59e4583 into master Aug 5, 2025
12 checks passed
@hslatman hslatman deleted the herman/fix-oidc-upgrade branch August 5, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants