Skip to content

Conversation

maraino
Copy link
Contributor

@maraino maraino commented Jul 15, 2025

This commit fixes a problem where step-ca hangs after a shutdown because errors were sent to a channel without enough capacity.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jul 15, 2025
@maraino maraino requested a review from hslatman July 15, 2025 18:16
@maraino maraino force-pushed the mariano/shutdown branch from ea6adb8 to 42fadfa Compare July 15, 2025 18:29
@maraino maraino requested review from smst-jeff and removed request for hslatman July 15, 2025 21:27
This commit fixes a problem where step-ca hangs after a shutdown because
errors were sent to a channel without enough capacity.
@maraino maraino force-pushed the mariano/shutdown branch from 42fadfa to a5fd0d0 Compare July 15, 2025 21:38
@smst-jeff
Copy link
Contributor

@maraino could this be rewritten using errgroup?

Copy link
Contributor

@smst-jeff smst-jeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think that is cleaner.

@maraino maraino merged commit 8537aa8 into master Jul 16, 2025
13 checks passed
@maraino maraino deleted the mariano/shutdown branch July 16, 2025 19:08
@hslatman hslatman added this to the v0.28.5 milestone Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants