Fix new golangci-lint issues
#2167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
hslatman
force-pushed
the
herman/upgrade-linter
branch
3 times, most recently
from
94b7f6e to
a1668d0
Compare
hslatman
changed the title
golangci-lint to v1.63.4golangci-lint to v1.64.4
This was referenced Feb 17, 2025
hslatman
force-pushed
the
herman/upgrade-linter
branch
from
a1668d0 to
21b9b02
Compare
hslatman
changed the title
golangci-lint to v1.64.4golangci-lint issues
hslatman
force-pushed
the
herman/upgrade-linter
branch
2 times, most recently
from
47aa32c to
0a97117
Compare
azazeal
requested changes
Feb 18, 2025
internal/cast/cast_test.go
Outdated
|
|
||
| func TestUintConvertsValues(t *testing.T) { | ||
| require.Equal(t, uint(0), Uint(0)) | ||
| require.Equal(t, uint(math.MaxInt64), Uint(math.MaxInt64)) |
There was a problem hiding this comment.
This will break on non-x64 platforms. You should probably swap math.MaxInt64 for math.MaxInt.
hslatman
force-pushed
the
herman/upgrade-linter
branch
from
0a97117 to
27944b4
Compare
azazeal
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.