Wire ACME improvements #1691
Merged
Wire ACME improvements #1691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
13 tasks
maraino
reviewed
Feb 6, 2024
acme/api/order.go
Outdated
| } | ||
|
|
||
| target, err = targetProvider.EvaluateTarget("") | ||
| target, err = wireOptions.GetOIDCOptions().EvaluateTarget("") |
There was a problem hiding this comment.
Do we ever pass the deviceID to these options?
There was a problem hiding this comment.
Need to check this one with Wire, as it may no longer be used after changing to two different identifier types. But maybe they still need it with a UserID instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.