Introduce SmallRyeConfig.subset #983
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gastaldi
commented
Aug 24, 2023
gastaldi
commented
- Fixes Support subsets from a Config #981
Contributor
Author
|
/cc @dmlloyd @radcortez |
gastaldi
force-pushed
the
subset
branch
3 times, most recently
from
71a57e5 to
3e9f521
Compare
dmlloyd
requested changes
Aug 24, 2023
Contributor
dmlloyd
left a comment
dmlloyd
left a comment
There was a problem hiding this comment.
I'd only make one change for now (make the implementation class non-public). There are a few other places which could be more optimal given some internal architecture changes (specifically, iterating the nested keys).
implementation/src/main/java/io/smallrye/config/SmallRyeSubsetConfig.java
Outdated
Show resolved
Hide resolved
gastaldi
force-pushed
the
subset
branch
4 times, most recently
from
58332c0 to
5b46b0c
Compare
dmlloyd
previously approved these changes
Aug 24, 2023
Contributor
dmlloyd
left a comment
dmlloyd
left a comment
There was a problem hiding this comment.
LGTM if @radcortez is OK with it.
Contributor
Author
|
Pushed a small fix that filters out properties that don't belong to the subset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.