Skip to content

Add py.typed #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add py.typed #68

wants to merge 1 commit into from

Conversation

heckad
Copy link

@heckad heckad commented May 18, 2024

#67

@spumer
Copy link
Collaborator

spumer commented May 18, 2024

I think we should add mypy checks too, because py.typed is conventions which means we are support typing

@alwavshumilin
Copy link

I think we should add mypy checks too, because py.typed is conventions which means we are support typing

This'll add way too much complexity to the proposed changes. Most of the project API's are typed incorrectly, hence it would require A LOT OF effort to rework (and probably re-design some parts of) this particular request

P.S. Issue states that this is a "good first issue", so I guess it's low-key unfair to ask 'heckad' to update the library core 😸

@spumer
Copy link
Collaborator

spumer commented Oct 29, 2024

@alwavshumilin i just mean add mypy to CI and make baseline

@alwavshumilin
Copy link

alwavshumilin commented Oct 31, 2024

@alwavshumilin i just mean add mypy to CI and make baseline

Well...if it's just for the sake of having 1 [additional] xfailing job, then I guess. But it has to be followed by an actual typing interface rework to fit into SAST

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants