Skip to content

Added control of remote RXes via Voter using a PTY (VOTER_PTY). #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

hsmade
Copy link

@hsmade hsmade commented Dec 30, 2015

Just echo into the VOTER_PTY: :0 to disable or :1 to enable.
This will mute the RX and set its status to disabled so it won't be selected by the voter anymore.
On enable, it becomes available for selection and the mute is set to none.
Also prints status on STATE_PTY (Voter:opr_state rx1:0 rx2:1) so it can be picked up by the perl script, for example.

…echo <rx name>:0 to disable or <rx name>:1 to enable. Also prints status on STATE_PTY
@pe1chl
Copy link
Contributor

pe1chl commented Jan 2, 2016

I think it is a great idea and a first start for the implementation of the enhancement described in issue #136.
However, I think it would be better to make a general PTY for sending commands to SvxLink and then interpret the commands and forward them to the proper part of SvxLink.
I.e. one can send commands like:

DTMF 123455   (the same that is already available on stdin when not running as daemon)
RxEnable rxname:1  (the thing that was added by this modification)

etc, and it can be extended with new commands when the need arises without having to create more and more PTYs.

@hsmade
Copy link
Author

hsmade commented Jan 6, 2016

I agree that this would be the correct solution. However, it's not that easy because the other PTY is handled by a different object which has no knowledge of the voter in that sense (as far as I could see). That's why I made it a separate PTY as a POC. I hope someone can take this code is a start to get it to the correct level.

I like your idea of sending DTMF through the PTY as well. This could be a start of better runtime administration and manipulation of svxlink.

wfournie added 11 commits January 7, 2016 22:38
Added workaround to still print the signal value for disabled RX
Cleanup of unused printOperState
Catch (possible) corner case where disabled Rx is selected
Created a way to set squelch to correct status after re-enable
Fixed a bug where an RX would be re-selected when the TX is still on.
KILL will disconnect the current talker, if there is one.
<CALL>:D will disconnect <CALL>
@hsmade hsmade closed this Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants