-
Couldn't load subscription status.
- Fork 97
Define a Drain::flush method #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a Drain::flush method #349
Conversation
5eda5fd to
901137d
Compare
Requires slog-rs/slog#349 to be accepted first.
Requires slog-rs/slog#349 to be accepted first.
Pinned to the branch used in slog-rs/slog#349, so that must be accepted first. The 'pretty' example is pinned to use the branch in slog-rs/async#39, so that must also be accepted first.
|
The goal here is to propagate any errors from the inside of the logging? The interface doesn't say anything about calling it multiple times. Probably good idea to say something, even if "is unspecified". |
A withdrawn proposal on a `FlushRequest` enum (too complex), }, NonBlocking, } ```
EDIT: For simplicity and consistency with
The goal is to flush buffered streams. Setting up a
Flushing should be idempotent. I will add this to the docs. |
ddc4252 to
52e5bc0
Compare
|
I have provided much more detailed documentation & made |
52e5bc0 to
9d7359e
Compare
9d7359e to
9406aa7
Compare
This is simpler than the API in slog-rs#332 , but requires more work by slog_async to implement it.
Requires either `feature = "std"` or core::error::Error (rust >= 1.81)
9406aa7 to
a59a459
Compare
Different from simple flush in PR slog-rs#349
This is simpler than the API in #332, but requires more work by
slog_asyncto implement it.See the implementation in slog-rs/async#39
All other slog libraries have a trivial implementation of this, so I will wait to add those those until (and if) this is accepted.