Skip to content

Reorganize MCU board support examples into modules #8794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

task-jp
Copy link
Contributor

@task-jp task-jp commented Jun 26, 2025

Move MCU board support example files into their own directories as mod.rs files.

@tronical
Copy link
Member

tronical commented Jul 3, 2025

Hmmm. I think the majority of modules in our repo don't use subdir/mod.rs. Is there a specific future change that you have in mind that benefits from this?

@task-jp
Copy link
Contributor Author

task-jp commented Jul 4, 2025

There is one source code and one directory for each board support, but IDE and file managers display directories and files separately (directories come first), so the two are separated, which is inconvenient.

If the source code could be moved under the directory, it would be much easier to work on board support tasks by working only under that directory. There is no strong intention to unify using mod.rs, so keeping the source file names as they are is fine.

Additionally, since it is anticipated that more board supports will be added in the future (right?), having the mcu-board-support directory clean and organised would be preferable.

@tronical
Copy link
Member

There is no strong intention to unify using mod.rs, so keeping the source file names as they are is fine.

Unless there's a good reason to handle things differently in this sub-directory, I'd prefer to keep a consistent way of handling modules across the entire repository then and not use mod.rs.

Move MCU board support example files into their own directories
@task-jp task-jp force-pushed the mcu-board-support-mod-rs branch from 6e36679 to e1f7992 Compare July 15, 2025 10:24
@task-jp
Copy link
Contributor Author

task-jp commented Jul 15, 2025

I kept file names as they were.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants