-
Notifications
You must be signed in to change notification settings - Fork 713
Add CMakePresets support #8739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMakePresets support #8739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the usecase? Is it to help people contributing to Slint? The extra .license file is a bit of noise and this information can be put in the REUSE.toml |
Yep it's mainly for helping people contributing to Slint. |
I like this, it looks like a very sane CMake config to suggest :-) Should we maybe go the full mile and suggest the skia backend? It has so much nicer fonts and all the tools to build skia should be available to somebody using CMake in the first place:-) |
I'm not sure it's a good idea of the presets to override the feature defaults. |
hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
hi, someone can merge it please ? :) |
Apologies for the delay. Merged now :) |
No description provided.