Standalone Live Preview #8538
Draft
Standalone Live Preview #8538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sort results based on the value the fuzzy matcher assigned to the match, while keeping the entries with the same value sorted alphabetically. Throw away the bottom half of the values if more than 10 results were found or return everything.
Now that all the code in preview.rs runs in the UI thread, we do not need to separate out some data into a threading aware part anymore. This leaves room for optimizations later: We can probably reduce the state we keep now.
... which contains the code used to connect the live preview with the outside world. For now the outside world is the LSP, but we want to eventually make the live preview runable without.
Run both the LSP and the Live Preview in a stand-alone process, independent of each other. This simplifies the threading setup a bit and points a way towards running the live preview cleanly in a stand-alone fashion. This si a half-way state, still TODO: * Remove dead code related to starting up the preview in a thread in parallel to the LSP * Check out how to do the WASM side of things. It is two separate binaries anyway, so that should nto be too hard * Make the code conenctiong the live preview to the LSP runtime-switchable, so that I can implement a version that does filesystem acces, etc. iteself without a LSP running. * Turn `preview.rs` into a object that I can store in a local variable and get rid of the thread-local. * Find all the bugs:-)
szecket
added
rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of work I started last week, cleaning up the live preview and sits on top of my PRs from Friday (which are included here again since that is how github works).
This is just a experiment I did over the WE, it is not polished (or even done:-). What it tries to do is this:
Have the LSP start the live preview by running
{argv[0} live-preview --remote-controlledand communicates via stdin/stdout with that. This makes the need for quite a bit of the complexity innative.rsgo away.Next steps are:
preview.rsinto a object that I can store in a local variable and get rid of the thread-local.After that a logical step would be to allow users to run
slint-lsp live-preview {file}and then use a differentconenctorto not talk to a LSP and just interact with the fielsystem directly.