figma-inspector: corrected overwrite of reused modes #8298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
It's a little scary that in generateStructsAndInstances, the collectionData argument so declared as any, and then passed to collectMultiModeStructs as-is, which is changed in this PR to expect this additional field. It would be worthwhile to also adjust the signature of generateStructsAndInstances to maintain type-safety.
szecket
force-pushed
the
szecket/push-trvokvwlvlyx
branch
from
fb9a4b3 to
49dbe98
Compare
tronical
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when combining collections, mode3_brush was too ambiguous.
now using _mode3_brush