SlevomatCodingStandard.TypeHints.ClassConstantTypeHint: fixing only private constants #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryo
force-pushed
the
class-constant-typehint-no-dangerous-fix
branch
from
0935511 to
249b563
Compare
|
Yes, please add new option because this change is also a BC break |
maryo
force-pushed
the
class-constant-typehint-no-dangerous-fix
branch
from
249b563 to
4b7dd5c
Compare
|
OK, I added |
|
Thanks. |
kukulich
force-pushed
the
class-constant-typehint-no-dangerous-fix
branch
from
4b7dd5c to
beba0ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is dangerous to automatically add typehints for other than private constants as the type might not be compatible with constants in the inheritance chain or implemented interfaces.
Or if you prefered this to be configurable, I could make it configurable.