Skip to content

RequireConstructorPropertyPromotion: Properly autofixing arguments with attribute #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RequireConstructorPropertyPromotion: Properly autofixing arguments with attribute #1754

wants to merge 1 commit into from

Conversation

maryo
Copy link
Contributor

@maryo maryo commented May 23, 2025 •
edited
Loading

It was incorrectly fixing to the following:

public function __construct(
-    #[\SensitiveParameter]
-    private string $login,
-    #[\SensitiveParameter]
-    private string $password
+    private #[\SensitiveParameter]
+    string $login,
+    private #[\SensitiveParameter]
+    string $password
) {

@maryo maryo changed the title RequireConstructorPropertyPromotion: Properly autofixing when argument name has an attribute RequireConstructorPropertyPromotion: Properly autofixing arguments with attribute May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maryo